Skip to content
This repository has been archived by the owner on Feb 28, 2019. It is now read-only.

Pull in latest m3metrics change and fix build and test #65

Merged
merged 4 commits into from
Jun 13, 2018

Conversation

xichen2020
Copy link
Contributor

cc @cw9 @jskelcy

This PR pulls in the latest m3metrics change to take advantage of consolidated data models and APIs.

"RollupRuleHistory": {
"Pipeline": {
"type": "array",
"items": {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because swagger 2.0 doesn't support oneOf in JSON schema.

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage decreased (-1.9%) to 38.184% when pulling 49a9d92 on xichen-pull-latest-m3metrics into 37a2ec5 on master.

Copy link
Contributor

@jskelcy jskelcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xichen2020 xichen2020 merged commit 747416c into master Jun 13, 2018
@xichen2020 xichen2020 deleted the xichen-pull-latest-m3metrics branch June 13, 2018 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants