Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Ignore replicas when checking for an update #238

Merged

Conversation

jeromefroe
Copy link
Collaborator

This commit updates the updatedStatefulSet method of the controller to ignore replicas when determining if it should update a StatefulSet. Changing the number of replicas in a cluster requires changes to the cluster's placement, which the controller already supports, so we can bypass checking the replicas in updatedStatefulSet to allow such changes to be processed by the controller later in the control loop.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   76.45%   76.45%           
=======================================
  Files          30       30           
  Lines        2170     2170           
=======================================
  Hits         1659     1659           
  Misses        379      379           
  Partials      132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b242e67...8339d72. Read the comment docs.

@jeromefroe jeromefroe merged commit fd5c37d into master Sep 30, 2020
@jeromefroe jeromefroe deleted the jerome/controller/ignore-replicas-when-checking-for-update branch September 30, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants