[config] Update default configuration template #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schallert
reviewed
Nov 25, 2020
assets/default-config.yaml
Outdated
| discovery: | ||
| config: | ||
| service: | ||
| env: "{{ .Env }}" |
There was a problem hiding this comment.
This should stay as default_env since it's not a templated file
schallert
approved these changes
Nov 25, 2020
jeromefroe
approved these changes
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 30 30
Lines 2240 2240
=======================================
Hits 1706 1706
Misses 393 393
Partials 141 141 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as the operator will not be able to create a working default configuration for m3db v1.0.0+. To use the new version of the operator with an older version of m3db you will have to provide a custom config map.
Please see m3db changelog for details.