Wait for replica to update pods before processing next statefulset update #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 75.54% 75.45% -0.09%
==========================================
Files 31 31
Lines 2437 2310 -127
==========================================
- Hits 1841 1743 -98
+ Misses 444 425 -19
+ Partials 152 142 -10 Continue to review full report at Codecov.
|
wesleyk
approved these changes
Jan 8, 2021
| simulatePodsNotUpdated: true, | ||
| expUpdateStatefulSets: []string{"cluster1-rep0", "cluster1-rep1", "cluster1-rep2"}, | ||
| expFailedUpdateStatefulSets: []string{"cluster1-rep1", "cluster1-rep2"}, | ||
| expNotDone: true, |
There was a problem hiding this comment.
for my own understanding: this would be false before your change?
There was a problem hiding this comment.
@wesleyk it was more that, before this change if simulatePodsNotUpdated had existed in this test code and the "UpdatedReplicas" did not match the expected replicas in the statefulset it would have progressed to update the next statefulset anyway.
schallert
approved these changes
Jan 8, 2021
jeromefroe
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for gating progression to updating the next statefulset until all pods have been updated, avoiding the statefulset looking "ready" and "healthy" even though it has a pending update which it's about to process (and start updating pods).