[k8sops] refactor label logic into separate pkg #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the core event loop to support the case where a cluster has pods which are not in the active placement. Also included are some changes to logging such that by default the controller runs with JSON logging, making integrations into higher-level log viewing tools easier (such as GKE + Stackdriver logging).
Taking label logic that was in various places and consolidate in one package.
schallert
force-pushed
the
schallert/labels_refactor
branch
from
89ebf88
to
9b24201
Compare
Codecov Report
@@ Coverage Diff @@
## schallert/handle_resize #42 +/- ##
==========================================================
+ Coverage 45.74% 46.04% +0.3%
==========================================================
Files 19 20 +1
Lines 1235 1253 +18
==========================================================
+ Hits 565 577 +12
- Misses 643 644 +1
- Partials 27 32 +5Continue to review full report at Codecov.
|
schallert
force-pushed
the
schallert/handle_resize
branch
2 times, most recently
from
c585aad
to
913b585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking label logic that was in various places and consolidate in one
package.
Depends on #29