Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coordinator docs #747

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

benraskin92
Copy link
Collaborator

No description provided.

Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## M3Coordinator

M3Coordinator is a coordination service that sits in between Prometheus and M3DB. It acts as a bridge for both reads and writes so that users can access all of the benefits of M3DB such as long term storage and multi DC setup without migrating off of Prometheus. See [this presentation](https://schd.ws/hosted_files/cloudnativeeu2017/73/Integrating%20Long-Term%20Storage%20with%20Prometheus%20-%20CloudNativeCon%20Berlin%2C%20March%2030%2C%202017.pdf) for more on long term storage in Prometheus.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to some official prometheus docs as well? Maybe this one if not others: https://prometheus.io/docs/operating/integrations/#remote-endpoints-and-storage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke offline

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ an additional link

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #747 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage   79.43%   79.31%   -0.13%     
==========================================
  Files         280      281       +1     
  Lines       26569    26534      -35     
==========================================
- Hits        21105    21045      -60     
- Misses       4186     4214      +28     
+ Partials     1278     1275       -3
Flag Coverage Δ
#cmd 59.63% <ø> (-2.64%) ⬇️
#coordinator 77.05% <ø> (+6.26%) ⬆️
#dbnode 80.79% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d3ecc...ef09cf4. Read the comment docs.

@benraskin92 benraskin92 merged commit 8fc7f1b into master Jun 5, 2018
@benraskin92 benraskin92 deleted the braskin/update_coordinator_docs branch June 5, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants