Embed bytes buffer in the buffered encoder

m3db · Mar 14, 2017 · 09592f0 · 09592f0
1 parent bb0fd6c
commit 09592f0
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/protocol/msgpack/buffered_encoder.go b/protocol/msgpack/buffered_encoder.go
@@ -29,7 +29,7 @@ import (
 type bufferedEncoder struct {
 	*msgpack.Encoder
 
-	buf    *bytes.Buffer
+	buf    bytes.Buffer
 	closed bool
 	pool   BufferedEncoderPool
 }
@@ -41,16 +41,13 @@ func NewBufferedEncoder() BufferedEncoder {
 
 // NewPooledBufferedEncoder creates a new pooled buffered encoder
 func NewPooledBufferedEncoder(p BufferedEncoderPool) BufferedEncoder {
-	buf := bytes.NewBuffer(nil)
-	return &bufferedEncoder{
-		Encoder: msgpack.NewEncoder(buf),
-		buf:     buf,
-		closed:  false,
-		pool:    p,
-	}
+	var enc bufferedEncoder
+	enc.Encoder = msgpack.NewEncoder(&enc.buf)
+	enc.pool = p
+	return &enc
 }
 
-func (enc *bufferedEncoder) Buffer() *bytes.Buffer { return enc.buf }
+func (enc *bufferedEncoder) Buffer() *bytes.Buffer { return &enc.buf }
 
 func (enc *bufferedEncoder) Bytes() []byte { return enc.buf.Bytes() }