[buffered encoder pool] Use an int for the maximum capacity

m3db · Aug 28, 2017 · 7aa4c18 · 7aa4c18
1 parent c373cff
commit 7aa4c18
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/protocol/msgpack/buffered_encoder_pool.go b/protocol/msgpack/buffered_encoder_pool.go
@@ -23,7 +23,7 @@ package msgpack
 import "github.com/m3db/m3x/pool"
 
 type bufferedEncoderPool struct {
-	maxCapacity int64
+	maxCapacity int
 	pool        pool.ObjectPool
 }
 
@@ -46,7 +46,7 @@ func (p *bufferedEncoderPool) Get() BufferedEncoder {
 }
 
 func (p *bufferedEncoderPool) Put(encoder BufferedEncoder) {
-	if int64(encoder.Buffer().Cap()) > p.maxCapacity {
+	if encoder.Buffer().Cap() > p.maxCapacity {
 		return
 	}
 	p.pool.Put(encoder)

diff --git a/protocol/msgpack/options.go b/protocol/msgpack/options.go
@@ -20,8 +20,11 @@
 
 package msgpack
 
-import xpool "github.com/m3db/m3x/pool"
-import "math"
+import (
+	"math"
+
+	xpool "github.com/m3db/m3x/pool"
+)
 
 const (
 	// The maximum capacity of buffers that can be returned to the buffered
@@ -49,7 +52,7 @@ const (
 )
 
 type bufferedEncoderPoolOptions struct {
-	maxCapacity int64
+	maxCapacity int
 	poolOpts    xpool.ObjectPoolOptions
 }
 
@@ -61,13 +64,13 @@ func NewBufferedEncoderPoolOptions() BufferedEncoderPoolOptions {
 	}
 }
 
-func (o *bufferedEncoderPoolOptions) SetMaxCapacity(value int64) BufferedEncoderPoolOptions {
+func (o *bufferedEncoderPoolOptions) SetMaxCapacity(value int) BufferedEncoderPoolOptions {
 	opts := *o
 	opts.maxCapacity = value
 	return &opts
 }
 
-func (o *bufferedEncoderPoolOptions) MaxCapacity() int64 {
+func (o *bufferedEncoderPoolOptions) MaxCapacity() int {
 	return o.maxCapacity
 }
 

diff --git a/protocol/msgpack/types.go b/protocol/msgpack/types.go
@@ -91,10 +91,10 @@ type BufferedEncoderPool interface {
 // BufferedEncoderPoolOptions provides options for buffered encoder pools.
 type BufferedEncoderPoolOptions interface {
 	// SetMaxCapacity sets the maximum capacity of buffers that can be returned to the pool.
-	SetMaxCapacity(value int64) BufferedEncoderPoolOptions
+	SetMaxCapacity(value int) BufferedEncoderPoolOptions
 
 	// MaxBufferCapacity returns the maximum capacity of buffers that can be returned to the pool.
-	MaxCapacity() int64
+	MaxCapacity() int
 
 	// SetObjectPoolOptions sets the object pool options.
 	SetObjectPoolOptions(value pool.ObjectPoolOptions) BufferedEncoderPoolOptions