Additional tests to improve code coverage

policy/policy_test.go

@@ -135,3 +135,49 @@ func TestNewPolicyFromSchema(t *testing.T) {
 		assert.Equal(t, test.expectedPolicy, actualPolicy)
 	}
 }
+
+func TestNewPoliciesFromSchema(t *testing.T) {
+	tests := []struct {
+		policies         []*schema.Policy
+		expectedPolicies []Policy
+		expectedErr      bool
+	}{
+		// invalid precision
+		{
+			policies: []*schema.Policy{
+				&schema.Policy{
+					Resolution: &schema.Resolution{WindowSize: 100, Precision: 42},
+					Retention:  &schema.Retention{Period: 20},
+				},
+			},
+			expectedErr: true,
+		},
+		// valid policy
+		{
+			policies: []*schema.Policy{
+				&schema.Policy{
+					Resolution: &schema.Resolution{WindowSize: 100, Precision: int64(time.Second)},
+					Retention:  &schema.Retention{Period: 20},
+				},
+			},
+			expectedPolicies: []Policy{
+				Policy{
+					resolution: Resolution{Window: 100, Precision: xtime.Second},
+					retention:  20,
+				},
+			},
+			expectedErr: false,
+		},
+	}
+
+	for _, test := range tests {
+		actualPolicies, actualErr := NewPoliciesFromSchema(test.policies)
+		if test.expectedErr {
+			assert.Error(t, actualErr)
+			continue
+		}
+
+		assert.NoError(t, actualErr)
+		assert.Equal(t, test.expectedPolicies, actualPolicies)
+	}
+}