This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Adding handler functions and tests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgromov
force-pushed
the
common_kv_functions
branch
from
d2c024c
to
b7768b2
Compare
xichen2020
reviewed
Jun 27, 2017
handlers/namespaces.go
Outdated
| return 0, nil, err | ||
| } | ||
| version := value.Version() | ||
| services := &schema.Namespaces{} |
There was a problem hiding this comment.
Rename services to namespaces since this is in OSS world and namespace is more generic than service.
Also, more idiomatic to write
var namespaces schema.Namespaces
if err := value.Unmarshal(&namespaces); err != nil {
...
}
handlers/namespaces.go
Outdated
| return namespacesVersion, namespaces, ns, nil | ||
| } | ||
|
|
||
| // Namespace returns the service with a given name, or an error if there are |
There was a problem hiding this comment.
returns the namespace with a given name
handlers/namespaces.go
Outdated
| return nil, errMultipleMatches | ||
| } | ||
| } | ||
| return namespace, nil |
There was a problem hiding this comment.
Perhaps better to return errNotFound if the namespace is nil here?
handlers/namespaces.go
Outdated
| if ns == nil { | ||
| return 0, nil, nil, fmt.Errorf("namespace %s doesn't exist", namespaceName) | ||
| } | ||
| if ns.Snapshots[len(ns.Snapshots)-1].Tombstoned { |
There was a problem hiding this comment.
Might be safer to check if len(ns.Snapshots) is nonzero and return an error if so.
handlers/ruleset.go
Outdated
| rollupRule *schema.RollupRule | ||
| ) | ||
| for _, mr := range ruleSet.MappingRules { | ||
| latestSnapshot := mr.Snapshots[len(mr.Snapshots)-1] |
There was a problem hiding this comment.
Check len(mr.Snapshots) is nonzero first?
handlers/ruleset.go
Outdated
| if mappingRule != nil && rollupRule != nil { | ||
| return nil, nil, errMultipleMatches | ||
| } | ||
| return mappingRule, rollupRule, nil |
There was a problem hiding this comment.
Return errNotFound if both are nil?
handlers/ruleset.go
Outdated
| return 0, nil, err | ||
| } | ||
| version := value.Version() | ||
| ruleSet := &schema.RuleSet{} |
There was a problem hiding this comment.
nit: more idiomatic to write var ruleSet schema.RuleSet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.