Use no pool in encoder/decoder by default (#56)

consumer/config_test.go

@@ -24,6 +24,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/m3db/m3x/instrument"
+
 	"github.com/stretchr/testify/require"
 	yaml "gopkg.in/yaml.v2"
 )
@@ -38,14 +40,20 @@ connectionWriteBufferSize: 200
 connectionReadBufferSize: 300
 encoder:
   maxMessageSize: 100
+  bytesPool:
+    watermark:
+      low: 0.001
 decoder:
   maxMessageSize: 200
+  bytesPool:
+    watermark:
+      high: 0.002
 `
 
 	var cfg Configuration
 	require.NoError(t, yaml.Unmarshal([]byte(str), &cfg))
 
-	opts := cfg.NewOptions(nil)
+	opts := cfg.NewOptions(instrument.NewOptions())
 	require.Equal(t, 5, opts.MessagePoolOptions().Size())
 	require.Equal(t, 100*time.Millisecond, opts.AckFlushInterval())
 	require.Equal(t, 100, opts.AckBufferSize())
@@ -55,5 +63,5 @@ decoder:
 	require.NotNil(t, opts.EncoderOptions().BytesPool())
 	require.Equal(t, 200, opts.DecoderOptions().MaxMessageSize())
 	require.NotNil(t, opts.EncoderOptions().BytesPool())
-	require.Nil(t, opts.InstrumentOptions())
+	require.Equal(t, instrument.NewOptions(), opts.InstrumentOptions())
 }

producer/config/writer_test.go

@@ -121,7 +121,5 @@ decoder:
 	require.Equal(t, 2*time.Millisecond, wOpts.AckErrorRetryOptions().InitialBackoff())
 	require.Equal(t, 5*time.Second, wOpts.ConnectionOptions().DialTimeout())
 	require.Equal(t, 100, wOpts.EncoderOptions().MaxMessageSize())
-	require.NotNil(t, wOpts.EncoderOptions().BytesPool())
 	require.Equal(t, 200, wOpts.DecoderOptions().MaxMessageSize())
-	require.NotNil(t, wOpts.DecoderOptions().BytesPool())
 }

protocol/proto/options.go

@@ -26,20 +26,11 @@ import (
 
 var (
 	defaultMaxMessageSize = 4 * 1024 * 1024 // 4MB.
-	defaultByteBuckets    = []pool.Bucket{
-		{Capacity: 4, Count: 4},    // Number of bytes for size.
-		{Capacity: 512, Count: 2},  // Number of bytes for message.
-		{Capacity: 1024, Count: 2}, // Number of bytes for ack with 100 metadata.
-		{Capacity: 2048, Count: 1}, // Number of bytes in case of large message or ack.
-	}
 )
 
 // NewOptions creates a new Options.
 func NewOptions() Options {
-	pool := pool.NewBytesPool(defaultByteBuckets, nil)
-	pool.Init()
 	return &options{
-		bytesPool:      pool,
 		maxMessageSize: defaultMaxMessageSize,
 	}
 }

protocol/proto/roundtrip_test.go

@@ -32,12 +32,12 @@ import (
 )
 
 func TestBaseEncodeDecodeRoundTripWithoutPool(t *testing.T) {
-	enc := NewEncoder(NewOptions().SetBytesPool(nil)).(*encoder)
+	enc := NewEncoder(NewOptions()).(*encoder)
 	require.Equal(t, 4, len(enc.buffer))
 	require.Equal(t, 4, cap(enc.buffer))
 	require.Empty(t, enc.Bytes())
 	r := bytes.NewReader(nil)
-	dec := NewDecoder(r, NewOptions().SetBytesPool(nil)).(*decoder)
+	dec := NewDecoder(r, NewOptions()).(*decoder)
 	require.Equal(t, 4, len(dec.buffer))
 	require.Equal(t, 4, cap(dec.buffer))
 	encodeMsg := msgpb.Message{