This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
Include metalinter config #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
force-pushed
the
prateek/fix-metalint-issues
branch
from
266e6a9
to
4ea1281
Compare
jeromefroe
approved these changes
Apr 3, 2018
| "golint", | ||
| "gosimple", | ||
| "unused", | ||
| "maligned" |
There was a problem hiding this comment.
Is it worth adding go vet and go fmt as well?
There was a problem hiding this comment.
opened #27 to track
index/segment/mem/iterator.go
Outdated
|
|
||
| err error | ||
| closed bool | ||
| maxID postings.ID |
There was a problem hiding this comment.
Is this because of structcheck? If so, is it worth preferring the old layout since it had the benefit of distinguishing immutable versus mutable fields.
There was a problem hiding this comment.
it's because of maligned: this layout is 80 bytes, the older one was 88.
I'll put a comment to indicate why we order this way and the mutability of fields.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.