set gokart.TaskOnKart.complete_check_at_run default True #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete RunWithLock delete old codes add test sort sort delete move rename test rename Change build backend to poetry-core (m3dev#355) Co-authored-by: Keisuke Ogaki <keisuke-ogaki@m3.com> allow distributing typed information (m3dev#356) * allow distributing typed information * restore include relax python constraint (m3dev#357) relock add Update docs/efficient_run_on_multi_workers.rst Co-authored-by: Keisuke OGAKI <hikingko1@gmail.com> set complete_check_at_run=False
mski-iksm
force-pushed
the
feature/complete_check_at_run_always_True
branch
from
1a64174
to
2d439f1
Compare
mski-iksm
requested review from
yokomotod,
Hi-king,
ukky17,
kitagry,
po3rin and
ujiuji1259
kitagry
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed gokart.TaskOnKart.complete_check_at_run to True by default.
This is to reduce parameter setting complexity.
reference: #353 (comment)