bugfix: FeatherFileProcessor set wrong index #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitagry
force-pushed
the
fix-feather-index
branch
from
28e7cd1
to
b306a5f
Compare
kitagry
requested review from
hirosassa,
yokomotod,
Hi-king,
mski-iksm and
ujiuji1259
yokomotod
reviewed
Mar 21, 2024
yokomotod
reviewed
Mar 21, 2024
yokomotod
approved these changes
Mar 21, 2024
kitagry
force-pushed
the
fix-feather-index
branch
from
f333392
to
e046e09
Compare
|
LGTM! Thank you for bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When original DataFrame doesn't set index name, FeatherFileProcessor set index_name as 'None'.
Why we don't fix
dumpnot to dump index None?It is important for the compatibility, the already dumped feather file has the name
__feather_gokart_index__None. And I think no one doesn't set"None"name index. 馃槈