add type aware flatten method instead of luigi.task.flatten
#362
+120
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TypeAlias is not support in Python3.9 😮💨 |
kitagry
force-pushed
the
add-flatten-method
branch
from
c60f535
to
2482321
Compare
kitagry
force-pushed
the
add-flatten-method
branch
from
2482321
to
6df1af1
Compare
kitagry
commented
Apr 8, 2024
gokart/utils.py
Outdated
| if sys.version_info >= (3, 10): | ||
| from typing import TypeAlias | ||
|
|
||
| FlattableItems: TypeAlias = T | Iterable['FlattableItems[T]'] | dict[str, 'FlattableItems[T]'] |
There was a problem hiding this comment.
TypeAlias is required in mypy. from Python 3.12, this will be replaced type statement
gokart/utils.py
Outdated
| else: | ||
| from typing import Union | ||
|
|
||
| FlattableItems = Union[T, Iterable['FlattableItems[T]'], dict[str, 'FlattableItems[T]']] |
There was a problem hiding this comment.
TypeAlias is not supported in Python 3.9. And, | is not supported.
kitagry
requested review from
hirosassa,
Hi-king,
tkda-h3,
mski-iksm and
ujiuji1259
Hi-king
reviewed
Apr 8, 2024
Hi-king
reviewed
Apr 8, 2024
mski-iksm
approved these changes
Apr 8, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
luigi.task.flatten, but this method is not type aware (it return type is alwaysUnknown. Because of this, we wrote missed type here ( it should beList[str], butList[TaskOnKart]).So, I introduce type aware flatten method instead of
luigi.task.flatten