Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.8.1 includes a breaking change #408

Closed
nox opened this issue Apr 29, 2024 · 1 comment
Closed

Version 0.8.1 includes a breaking change #408

nox opened this issue Apr 29, 2024 · 1 comment

Comments

@nox
Copy link

nox commented Apr 29, 2024

Adding feature te to if_everything is a breaking change that causes cargo-deny 0.4.22 to not build anymore.

cargo-deny depends on goblin 0.8 with a specific set of features and with default-features disabled

# Native executable detection
goblin = { version = "0.8", default-features = false, features = [
  "elf32",
  "elf64",
  "mach32",
  "mach64",
  "pe32",
  "pe64",
] }

It then uses goblin::peek_bytes.

For peek_bytes to be enabled in goblin 0.8.1, cargo-deny now needs to enable feature "te":

goblin/src/lib.rs

Lines 238 to 248 in f025d49

macro_rules! if_everything {
($($i:item)*) => ($(
#[cfg(all(feature = "endian_fd", feature = "elf64", feature = "elf32", feature = "pe64", feature = "pe32", feature = "te", feature = "mach64", feature = "mach32", feature = "archive"))]
$i
)*)
}
if_everything! {
/// Peeks at `bytes`, and returns a `Hint`
pub fn peek_bytes(bytes: &[u8; 16]) -> error::Result<Hint> {

Please yank 0.8.1 and re-release as 0.9.0.

@m4b
Copy link
Owner

m4b commented Jul 28, 2024

this was done, thank you for pointing this out!

@m4b m4b closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants