feat: support glob pattern for disabled_filetypes #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m4xshen please, take a look at this. |
|
@heywhy Sorry I've been busy recently. I'll review this today asap! |
|
@heywhy I just rewrote the matching logic and removed the redundant part. It should work same as before. If this looks good to you I'll merge it! |
|
LGTM! I apologize for my cranky implementation, I have little to no knowledge of Lua. 😄 |
|
Great, thanks for your contribution ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying buffer types (to disable hardtime for) individually can be tedious, especially for buffers that share a common prefix like
Neogit, so I've included a small glob-like support that allows users to specifyNeogit*and it matches all Neogit buffers.