Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

++ Added char map to slugify words with accents and special chars. #5

Closed
wants to merge 1 commit into from

Conversation

ericzon
Copy link

@ericzon ericzon commented Nov 23, 2014

I'm using your great set of components and I needed to slugify words with accents.
Before "ÁÉÍÓÚáéíóú" turned into "", now it turns into: "aeiouaeiou". Hope this helps.

@m59peacemaker
Copy link
Owner

@ericzon great idea! I hadn't thought about that possibility. I think it makes more sense to have a function which has the sole responsibility of replacing accented characters, and just use that function prior to slugifying where needed. That way, you can reuse the accent stripping function in other contexts and keep the slugify function lighter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants