data cleanup refactoring

m9 · Sep 21, 2012 · ba08739 · ba08739
1 parent 509b793
commit ba08739
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/hipchat.coffee b/src/hipchat.coffee
@@ -104,13 +104,11 @@ class HipChatClient
       password: params.password
       timezone: params.timezone ? 'UTC'
 
-    for k,v of data
-      delete data[k] unless params[k]?
 
     options = @_prepareOptions
       method: 'post'
       path:   '/v1/users/create'
-      data:   data
+      data:   @_cleanupData data, params
 
 
     @_sendRequest options, callback  
@@ -126,12 +124,10 @@ class HipChatClient
       password: params.password
       timezone: params.timezone ? 'UTC' 
 
-
-
     options = @_prepareOptions
       method: 'post'
       path:   '/v1/users/update'
-      data:   data
+      data:   @_cleanupData data, params
 
     @_sendRequest options, callback  
 
@@ -176,6 +172,7 @@ class HipChatClient
     if options.data? then req.write('' + options.data)
     req.end()
 
+  # Removes all unused keys from array before making request
   _cleanupData: (data, params) ->
     for k,v of data
       delete data[k] unless params[k]?