Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Secret Admin field should be type password, not type text #124

Closed
benbalter opened this issue Jan 14, 2016 · 1 comment
Closed

GitHub Secret Admin field should be type password, not type text #124

benbalter opened this issue Jan 14, 2016 · 1 comment
Labels
enhancement

Comments

@benbalter
Copy link
Collaborator

Super minor, but on GitHub, the secret is masked on input. Tried to make the change myself, but wasn't sure the best way to implement it, as type="text" is currently hardcoded.
@mAAdhaTTah
Copy link
Owner

Oh yeah, cuz we're still using that partial. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benbalter @mAAdhaTTah