Allow PORT environment to be not set
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It's quite weird to require the `PORT` environment to be set, when it already can be set via the config file.
realaravinth
requested changes
Oct 17, 2022
src/settings.rs
Outdated
| @@ -170,7 +170,7 @@ impl Settings { | |||
| Ok(val) => { | |||
| s.set("server.port", val).unwrap(); | |||
| } | |||
| Err(e) => warn!("couldn't interpret PORT: {}", e), | |||
| _ => (), | |||
There was a problem hiding this comment.
Rather than completely removing the warning message, can you move it the Ok() block and convert it into an info message?
I've faced issues trying to host other software where I couldn't tell if my environment variable was being read or not 😅
There was a problem hiding this comment.
Suggested change
| _ => (), | |
| If let Ok(val) = env::var("PORT") { | |
| s.set("server.port", val).unwrap(); | |
| log:info!("Overriding port with environment variable"); | |
| } | |
There was a problem hiding this comment.
I have added a few more points of logging in this file: 9fd8ffd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PORTenvironment to be set, when it already can be set via the config file.