Fix compiling #51
Merged
Fix compiling #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I made some mistakes while checking my two previous PRs(Seems like I don't understand Rust that great after all). - Do the url encoding only on the password part, not only the whole URL. - Fix `temporary value dropped while borrowed` compile error.
realaravinth
requested changes
Oct 24, 2022
| log::info!("{}", format!("Loading config file from {}", absolute_path)); | ||
| s.merge(File::with_name(absolute_path))?; | ||
| let absolute_path = Path::new(&path).canonicalize().unwrap(); | ||
| log::info!( |
There was a problem hiding this comment.
format! is redundant here, log::info! macro is capable of formatting, just like format! and print!
| let absolute_path = fs::canonicalize(CURRENT_DIR).unwrap().to_str().unwrap(); | ||
| log::info!("{}", format!("Loading config file from {}", absolute_path)); | ||
| let absolute_path = fs::canonicalize(CURRENT_DIR).unwrap(); | ||
| log::info!( |
There was a problem hiding this comment.
redundant format!, please see above comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary value dropped while borrowedcompile error.