Format android getAllItems data and ts types to match iOS implementation #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamRaymer
force-pushed
the
normalize-getallitems-data
branch
2 times, most recently
from
87566e9
to
47d192a
Compare
This comment has been minimized.
This comment has been minimized.
SamRaymer
force-pushed
the
normalize-getallitems-data
branch
from
47d192a
to
5249e0a
Compare
SamRaymer
force-pushed
the
normalize-getallitems-data
branch
from
5249e0a
to
dee7455
Compare
mCodex
approved these changes
Nov 12, 2019
|
I think you should bump up the version (5.5.4) to major release. I am using react native and publishing only android app, and this minor release just broke my app because getAllItems response was changed to array from map. I think a lot of people will face this issue otherwise.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breaks the android return format, but matches the typescript definitions to the format in the iOS version of the native module.
I suggest a major version bump upon release to reflect the breaking change.