This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
Fixed socket creation timeouts #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdinn
added a commit
that referenced
this pull request
Sep 12, 2014
Fixed socket creation timeouts
|
Nice fix, good library hardening. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With poll-timeout > new-socket-timeout : In ZeroMQExtension if a socket creation is attempted before the initialization of the PUB/SUB sockets used to send interrupts, the SocketManager poller.poll (line59) will block the Actor thread and prevent any socket creation (NewSocket).
Due to the fact that actorOf[SocketManager] is async, Tests were randomly passing since SocketManager was receiving NewSocket before its Poll message sent at initialization.