Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add check next to active workspace #139

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Fix: add check next to active workspace #139

merged 5 commits into from
Mar 14, 2024

Conversation

jared-dickman
Copy link
Collaborator

@jared-dickman jared-dickman commented Mar 14, 2024 •
edited
Loading

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add checkmark next to active workspace, per the mocks
  • Add wrapping in un-breakable long workspace/account/org names, to avoid horizontal scroll bar

Testing Plan

  • Was this tested locally? If not, explain why.
  • testing in storybook for all GlobalNavigation stories

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Screenshots

image image image

tibuurcio
tibuurcio approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jared-dickman jared-dickman merged commit 786f7af into main Mar 14, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Closed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibuurcio tibuurcio tibuurcio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jared-dickman @tibuurcio