Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Document linting and formatting decisions #95

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

tibuurcio
Copy link
Collaborator

Summary

This PR documents our current linting and formatting decisions on the Aquarium

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)


That's our current config file for prettier:

```json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link to the config instead of copying it - this is unlikely to be updated when the config actually changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes definitely, good catch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be so nice to have something like Notion blocks that sync ⭐

Copy link
Collaborator

@jared-dickman jared-dickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super!

@tibuurcio tibuurcio merged commit 9b2c61b into main Feb 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants