fix: Remove Unnecessary Synchronize in Dealloc (#169)

mParticle · Nov 30, 2022 · 624891b · 624891b
1 parent a288ba4
commit 624891b
Showing 1 changed file with 0 additions and 20 deletions.
diff --git a/mParticle-Apple-SDK/Utils/MPApplication.m b/mParticle-Apple-SDK/Utils/MPApplication.m
@@ -77,7 +77,6 @@ @interface MParticle ()
 @interface MPApplication() {
     NSDictionary *appInfo;
     MPIUserDefaults *userDefaults;
-    BOOL syncUserDefaults;
 }
 
 @end
@@ -98,21 +97,12 @@ - (id)init {
     }
 
     userDefaults = [MPIUserDefaults standardUserDefaults];
-    syncUserDefaults = NO;
 
     _dyld_register_func_for_add_image(addImageListCallback);
 
     return self;
 }
 
-- (void)dealloc {
-    if (syncUserDefaults) {
-        dispatch_async(dispatch_get_main_queue(), ^{
-            [[MPIUserDefaults standardUserDefaults] synchronize];
-        });
-    }
-}
-
 - (NSString *)description {
     return [NSString stringWithFormat:@"%@", [self dictionaryRepresentation]];
 }
@@ -200,7 +190,6 @@ - (NSNumber *)initialLaunchTime {
     if (_initialLaunchTime == nil) {
         _initialLaunchTime = MPCurrentEpochInMilliseconds;
         userDefaults[kMPAppInitialLaunchTimeKey] = _initialLaunchTime;
-        syncUserDefaults = YES;
     }
 
     return _initialLaunchTime;
@@ -222,7 +211,6 @@ - (NSNumber *)lastUseDate {
 
 - (void)setLastUseDate:(NSNumber *)lastUseDate {
     userDefaults[kMPAppLastUseDateKey] = lastUseDate;
-    syncUserDefaults = YES;
 }
 
 - (NSNumber *)launchCount {
@@ -232,7 +220,6 @@ - (NSNumber *)launchCount {
 
 - (void)setLaunchCount:(NSNumber *)launchCount {
     userDefaults[kMPAppLaunchCountKey] = launchCount;
-    syncUserDefaults = YES;
 }
 
 - (NSNumber *)launchCountSinceUpgrade {
@@ -242,7 +229,6 @@ - (NSNumber *)launchCountSinceUpgrade {
 
 - (void)setLaunchCountSinceUpgrade:(NSNumber *)launchCountSinceUpgrade {
     userDefaults[kMPAppLaunchCountSinceUpgradeKey] = launchCountSinceUpgrade;
-    syncUserDefaults = YES;
 }
 
 - (NSNumber *)pirated {
@@ -261,8 +247,6 @@ - (void)setStoredBuild:(NSString *)storedBuild {
     } else {
         [userDefaults removeMPObjectForKey:kMPAppStoredBuildKey];
     }
-
-    syncUserDefaults = YES;
 }
 
 - (NSString *)storedVersion {
@@ -276,8 +260,6 @@ - (void)setStoredVersion:(NSString *)storedVersion {
     } else {
         [userDefaults removeMPObjectForKey:kMPAppStoredVersionKey];
     }
-
-    syncUserDefaults = YES;
 }
 
 - (NSNumber *)upgradeDate {
@@ -287,7 +269,6 @@ - (NSNumber *)upgradeDate {
 
 - (void)setUpgradeDate:(NSNumber *)upgradeDate {
     userDefaults[kMPAppUpgradeDateKey] = upgradeDate;
-    syncUserDefaults = YES;
 }
 
 - (NSString *)version {
@@ -321,7 +302,6 @@ - (void)setBadgeNumber:(NSNumber * _Nullable)badgeNumber {
     if (![MPStateMachine isAppExtension]) {
         MPIUserDefaults *userDefaults = [MPIUserDefaults standardUserDefaults];
         userDefaults[kMPAppBadgeNumberKey] = badgeNumber;
-        syncUserDefaults = YES;
     }
 }
 #endif