Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add filtering check to legacy code path #155

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix: Add filtering check to legacy code path #155

merged 1 commit into from
Jul 15, 2022

Conversation

peterjenkins
Copy link
Contributor

Summary

Add filtering check to legacy code path

Testing Plan

Manual testing

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-4319

@peterjenkins peterjenkins self-assigned this Jul 15, 2022
@peterjenkins peterjenkins changed the base branch from main to development July 15, 2022 18:47
einsteinx2
einsteinx2 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge, we tested together and it works as expected

@peterjenkins peterjenkins merged commit 0212944 into development Jul 15, 2022
@peterjenkins peterjenkins deleted the fix/4319-add-filtering-check-to-legacy-code-path branch July 15, 2022 18:57
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 15, 2022
@mparticle-automation
chore(release): 8.8.1 [skip ci]
1671456 
## [8.8.1](v8.8.0...v8.8.1) (2022-07-15)

### Bug Fixes

* Add filtering check to legacy code path ([#155](#155)) ([0212944](0212944))
* remove undefined hasher behavior ([#152](#152)) ([a82b928](a82b928))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@peterjenkins peterjenkins

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterjenkins @mparticle-automation @einsteinx2