Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove Undefined Hasher Behavior #152

Merged
merged 2 commits into from
May 18, 2022
Merged

fix: Remove Undefined Hasher Behavior #152

merged 2 commits into from
May 18, 2022

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

Replaced signed that have undefined behavior with more appropriate unsigned types

Testing Plan

Our HasherTest Unit tests continued to succeed with this change and no unexpected behavior was experienced while testing with the sample app

Master Issue

Closes https://mparticle-eng.atlassian.net/browse/SQDSDKS-3659

@BrandonStalnaker BrandonStalnaker self-assigned this May 18, 2022
@BrandonStalnaker BrandonStalnaker changed the base branch from main to development May 18, 2022 13:09
@BrandonStalnaker BrandonStalnaker force-pushed the fix/3659-Remove-Undefined-Hasher-Behavior branch from c81a759 to f4937de Compare May 18, 2022 13:10
@BrandonStalnaker BrandonStalnaker changed the title Remove Undefined Hasher Behavior fix: Remove Undefined Hasher Behavior May 18, 2022
@BrandonStalnaker BrandonStalnaker force-pushed the fix/3659-Remove-Undefined-Hasher-Behavior branch from f4937de to 31d1dec Compare May 18, 2022 13:24
@BrandonStalnaker BrandonStalnaker force-pushed the fix/3659-Remove-Undefined-Hasher-Behavior branch from 31d1dec to 29befe0 Compare May 18, 2022 15:38
einsteinx2
einsteinx2 approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit a82b928 into development May 18, 2022
@BrandonStalnaker BrandonStalnaker deleted the fix/3659-Remove-Undefined-Hasher-Behavior branch May 18, 2022 15:56
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 15, 2022
@mparticle-automation
chore(release): 8.8.1 [skip ci]
1671456 
## [8.8.1](v8.8.0...v8.8.1) (2022-07-15)

### Bug Fixes

* Add filtering check to legacy code path ([#155](#155)) ([0212944](0212944))
* remove undefined hasher behavior ([#152](#152)) ([a82b928](a82b928))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@peterjenkins peterjenkins peterjenkins approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BrandonStalnaker @mparticle-automation @einsteinx2 @peterjenkins