Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare sample app for iOS 16 #158

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

Minor updates to the the bundled sample app to support iOS 16. No actual changes to the SDK.

Testing Plan

Tested in simulator for iPhone and iPad

Master Issue

Closes https://mparticle-eng.atlassian.net/browse/SQDSDKS-4290

@BrandonStalnaker BrandonStalnaker self-assigned this Aug 5, 2022
@BrandonStalnaker BrandonStalnaker changed the base branch from main to development August 5, 2022 13:27
@BrandonStalnaker BrandonStalnaker changed the title Feat/4290 prepare sample app for iOS 16 feat: prepare sample app for iOS 16 Aug 5, 2022
@BrandonStalnaker BrandonStalnaker force-pushed the feat/4290-Prepare-Sample-App-For-iOS-16 branch from 3927077 to 7a6db90 Compare August 5, 2022 13:50
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit abc8e9e into development Aug 10, 2022
@BrandonStalnaker BrandonStalnaker deleted the feat/4290-Prepare-Sample-App-For-iOS-16 branch August 10, 2022 15:06
einsteinx2 pushed a commit that referenced this pull request Nov 30, 2022
mparticle-automation added a commit that referenced this pull request Nov 30, 2022
# [8.9.0](v8.8.1...v8.9.0) (2022-11-30)

### Bug Fixes

* Add class checks to initialize methods ([#165](#165)) ([065df46](065df46))
* Add Hash Methods where isEqual called ([#167](#167)) ([7302e0d](7302e0d))
* Allow null event attributes ([#163](#163)) ([5fd25c6](5fd25c6))
* Move dyld register callback to initialize ([#170](#170)) ([49d3660](49d3660))
* Remove unnecessary calls to removeObserver ([#168](#168)) ([a288ba4](a288ba4))
* Remove Unnecessary Synchronize in Dealloc ([#169](#169)) ([624891b](624891b))

### Features

* match android type support for custom attributes ([#157](#157)) ([c9a34cd](c9a34cd))
* Remove depreciate MPSegment code ([#171](#171)) ([1c04262](1c04262))
* Update Sample App for iOS 16 ([#158](#158)) ([fed8131](fed8131))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants