Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5343 Refactor Kit Filter Hash Functions #228

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Currently the code that hashes each value and compares those hashes to the ones from the kit config is scattered all over the codebase. Since we’ll need to reuse that code in the MPSideloadedKit class to implement the “add filter” methods, we should first refactor it into a static utility class.

Testing Plan

  • Tested locally and with new unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Oct 9, 2023
@BrandonStalnaker BrandonStalnaker force-pushed the feat/5343-Refactor-Kit-Filter-Hash-Functions branch from c61270c to d1265dd Compare October 11, 2023 15:00
@BrandonStalnaker BrandonStalnaker force-pushed the feat/5343-Refactor-Kit-Filter-Hash-Functions branch from d1265dd to f290a7b Compare October 11, 2023 15:09
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding all the tests!

@BrandonStalnaker BrandonStalnaker merged commit 5c26a9e into development Oct 16, 2023
15 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/5343-Refactor-Kit-Filter-Hash-Functions branch October 16, 2023 16:25
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Nov 30, 2023
# [8.17.0](v8.16.0...v8.17.0) (2023-11-30)

### Bug Fixes

* CFNetwork upload warning setting body twice ([#240](#240)) ([0a177f9](0a177f9))

### Features

* 5343 Refactor Kit Filter Hash Functions ([#228](#228)) ([5c26a9e](5c26a9e))
* Begin Implementation MPSideloadedKit Filtering Methods ([#231](#231)) ([ad543fb](ad543fb))
* Finish Implementation of MPSideLoadedKits ([#239](#239)) ([96e62f5](96e62f5))
* Improve background batch uploading and session management ([#238](#238)) ([dc6a9cb](dc6a9cb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants