Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Finish Implementation of MPSideLoadedKits #239

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Connected sideloaded kit filter configurations to mparticleoptions nad added unit test for all filters

Testing Plan

  • Added unit tests and tested manually

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

UnitTests/MPKitContainerTests.m Outdated Show resolved Hide resolved
UnitTests/MPKitContainerTests.m Outdated Show resolved Hide resolved
UnitTests/MPKitContainerTests.m Outdated Show resolved Hide resolved
UnitTests/MPKitContainerTests.m Outdated Show resolved Hide resolved
UnitTests/MPKitContainerTests.m Outdated Show resolved Hide resolved
BrandonStalnaker and others added 2 commits November 14, 2023 13:17
Co-authored-by: Ben Baron <bbaron@mparticle.com>
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the super comprehensive tests!!

@BrandonStalnaker BrandonStalnaker merged commit 96e62f5 into development Nov 15, 2023
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/5345-Finish-Sideloaded-Kit-Implementation branch November 15, 2023 13:54
@samdozor samdozor self-requested a review November 15, 2023 15:38
Copy link
Member

@samdozor samdozor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approved for blackout.

@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Nov 30, 2023
# [8.17.0](v8.16.0...v8.17.0) (2023-11-30)

### Bug Fixes

* CFNetwork upload warning setting body twice ([#240](#240)) ([0a177f9](0a177f9))

### Features

* 5343 Refactor Kit Filter Hash Functions ([#228](#228)) ([5c26a9e](5c26a9e))
* Begin Implementation MPSideloadedKit Filtering Methods ([#231](#231)) ([ad543fb](ad543fb))
* Finish Implementation of MPSideLoadedKits ([#239](#239)) ([96e62f5](96e62f5))
* Improve background batch uploading and session management ([#238](#238)) ([dc6a9cb](dc6a9cb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants