feat: Direct routing to correct pod #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markvdouw
reviewed
Sep 29, 2023
|
|
||
| - (NSString *)defaultHostWithSubdomain:(NSString *)subdomain apiKey:(NSString *)apiKey enableDirectRouting:(BOOL)enableDirectRouting { | ||
| if (enableDirectRouting) { | ||
| NSArray *splitKey = [apiKey componentsSeparatedByString:@"-"]; |
There was a problem hiding this comment.
What would happen if the subdomian doesnt have the - for splitting?
There was a problem hiding this comment.
if the API key doesn't have a dash (aka it's an old key without a prefix) this will just return an array with a single value, which I check for on the next line.
markvdouw
approved these changes
Sep 29, 2023
einsteinx2
merged commit b0701a1
into
feat/SQDSDKS-5764-api-url-routing-feature-branch
14 of 15 checks passed
einsteinx2
added a commit
that referenced
this pull request
Oct 9, 2023
einsteinx2
added a commit
that referenced
this pull request
Oct 11, 2023
mparticle-automation
added a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)