Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating metadata in the 0.4.0 release deletes watched status and date from the metadata #65

Closed
3 tasks done
ltctceplrm opened this issue Oct 15, 2022 · 5 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@ltctceplrm
Copy link
Contributor

  • The Plugin is up to date
  • Obsidian is up to date

Describe the bug
When you use the new "update metadata" option in the 0.4.0 release it deletes watched status and date from the metadata.

To Reproduce
Steps to reproduce the behavior:

  1. Add a movie using the plugin
  2. Change watched: false to watched: true and add a date for lastWatched: ""
  3. Press the button to update the metadata
  4. watched: and lastWatched: both disappear

Expected behavior
Reloading the information from omdb while retaining watched status and date.

Occurs on

  • Windows

Plugin version
0.4.0

Additional context
It looks like the same happens when you choose to update the entire note, it gets recreated without the note content which is expected but it also doesn't add the watched: or lastWatched: and just seems to skip that.

I hope I'm not a bother by posting a bug so soon after the release, especially since I love the new UI for remapping/excluding metadata.

@ltctceplrm ltctceplrm added the bug Something isn't working label Oct 15, 2022
@mProjectsCode
Copy link
Owner

that is strange, i will take a look at that

@mProjectsCode
Copy link
Owner

I hope I'm not a bother by posting a bug so soon after the release, especially since I love the new UI for remapping/excluding metadata.

No, issues are always welcome :)
And I am glad that you like the new UI

@mProjectsCode
Copy link
Owner

I have a fix ready, but i will wait a few hours or until tomorrow to test it a bit more.
I don't want to add more bugs xD

mProjectsCode added a commit that referenced this issue Oct 16, 2022
@mProjectsCode
Copy link
Owner

fixed in 0.4.1

@ltctceplrm
Copy link
Contributor Author

Thank you, it works great and even works for any other metadata that I've added myself afterwards, this is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants