Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mros2 frag msg proto #33

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

smoriemb
Copy link
Contributor

@smoriemb smoriemb commented Jan 5, 2023

This pull request is to have mROS2 on Mbed use the additional feature (fragmented data sending) added in the PR below.
[embeddedRTPS]
mROS-base/embeddedRTPS#11
[mROS2]
mROS-base/mros2#36

The modifications are below.

  • Modifications for the custom messages to go along with the pull requests above
  • Added two sample programs to demonstrate the new feature by publishing rather large messages.

Like mROS-base/mros2#36 above, this pull-request points to a submodule (mROS2) in my repository. I will update it to point to this repository after discussion.

@smoriemb
Copy link
Contributor Author

smoriemb commented Jan 5, 2023

@takasehideki
mROS-base/embeddedRTPS#11

But I think that we simply need to prepare long_text.txt for this requirement. And also, I think that modifying CMakeLists.txt will need to be maintained for future use.
Please simply prepare long_text.txt?

I had the same concern as you. I'd appreciate it if you could prepare some license-free documents to be stored. I passed the idea to store a novel from "Project Gutenberg" or something because I'm not sure if their license is OK to store there.
Is there any license-free document that belongs to you or your institute?

@takasehideki
Copy link
Member

@smoriemb My idea is to locate the text file generated from README.md under Git control by executing commands in the following script manually once first.
main...smoriemb:mros2-mbed:feature/mros2-frag-msg-proto#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

@smoriemb
Copy link
Contributor Author

My idea is to locate the text file generated from README.md under Git control by executing commands in the following script manually once first.

I've modified as you mentioned.

@takasehideki
Copy link
Member

going to be merging! along with mROS-base/embeddedRTPS#11 mROS-base/mros2#36 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants