Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify IP setting for RTPS, and separate platform dependent code from workspace #42

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

takasehideki
Copy link
Member

@takasehideki takasehideki commented Sep 9, 2023

Previously, IP address settings were required in both ./include/config/rtps.h and in app.cpp, but I could solve this situation so that it can work with only one setting, in ./platform/mros2-platform.h.
After the network configuration is complete, the program obtains the IP address and stores it to the configuration for embeddedRTPS (rtps::Config::IP_ADDRESS). This may increase the implementation responsibility for each platform, but I believe it should be more convenient for the user.

We have confirmed that this works only with mros2-mbed / echoback_string. Please check along with the following.
mROS-base/mros2#45

Below is the list to be tested

  • mandatory
    • echoback_string
    • echoreply_string
    • pub_float32
    • pub_twist
    • sub_pose
    • sub_uint16
    • pub_image
    • pub_long_string_sub_crc
  • optional (platform dependent and/or needs additional equipment)
    • mturtle_teleop
    • mturtle_teleop_joy
    • pub_camera_image

@takasehideki
Copy link
Member Author

@s-hosoai I added the list to be tested. I think this PR can be merged when all operations of "mandatory" can be confirmed.

@takasehideki
Copy link
Member Author

I've checked all operations of "mandatory" examples! I've also confirmed the build of "optional" examples, but not confirmed the operations yet due to a lack of modules,,, Anyway, going to be merged!!

@takasehideki takasehideki merged commit 88d4a9f into main Sep 13, 2023
@takasehideki takasehideki deleted the separate_target branch September 13, 2023 07:44
takasehideki added a commit that referenced this pull request Sep 13, 2023
@takasehideki takasehideki mentioned this pull request Sep 13, 2023
kazu-321 added a commit to kazu-321/minirobo that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant