MR-642-1133-1908_Custom_Icons_Folder_Icons

[brad457]

Issues 642 , 1133, and 1908 are all bugs around the way that Connection / Folder icons work. 642 and 1133 both are about folder icons not working, and 1133 also covers being able to add custom icons through the UI. 1908 is about how icons places in subfolders of the icon directory will show up in the Config Icon ComboBox but when selected not Icon is displayed. This will solve all 3 issues.

Motivation and Context

Helping out the project to fix open issues
642
1133
1908

How Has This Been Tested?

I've tested this locally for about 2 weeks.
Tested on Windows 10 (64-bit) using the latest development branch of this project.
I've tested this with versions of confCons.xml that were created brand new using the latest release, and a few confCons.xml that were created from older versions. No issues that I have seen.

Screenshots (if appropriate):

Types of changes

• [ X ] Bug fix (non-breaking change which fixes an issue)
• [ X ] New feature (non-breaking change which adds functionality)
• [ X ] Changed feature (non-breaking change which changes functionality)
• Changed feature (breaking change which changes functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Updated translation

Checklist:

• [ X ] I have read the CONTRIBUTING document.
• [ X ] My code follows the code style of this project.
• All Tests within VisualStudio are passing
• [ X ] This pull request does not target the master branch.
• I have updated the changelog file accordingly, if necessary.
• I have updated the documentation accordingly, if necessary.

[farosch]

Hi @brad457 Unfortunately it looks like you did something wrong when submitting this PR. First it is only a draft and second it wants to merge from mremoteNG/master into mremoteNG/develop which doesn't make any sense.
You will have to submit a new PR from whatever branch you were working on.

[Kvarkas]

as author don't response and its not clear that is suppose to be committed I decide to close such as incomplete and unclear.