Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for gatewayaccesstoken #2462

Merged
merged 2 commits into from Jul 18, 2023
Merged

Support for gatewayaccesstoken #2462

merged 2 commits into from Jul 18, 2023

Conversation

jurepurgar
Copy link

@jurepurgar jurepurgar commented Jul 18, 2023

Description

Resolves #2461.

Motivation and Context

Support for RD gateways with pluggable authentication

How Has This Been Tested?

Tried to connect from mRemote via RD gateway configured with pluggable authentication. The RDP connection was successful.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Changed feature (non-breaking change which changes functionality)
  • Changed feature (breaking change which changes functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated translation

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All Tests within VisualStudio are passing
  • This pull request does not target the master branch.
  • I have updated the changelog file accordingly, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jurepurgar jurepurgar changed the title WIP: Support for gatewayaccesstoken Support for gatewayaccesstoken Jul 18, 2023
@jurepurgar
Copy link
Author

@Kvarkas I'm first time contributor to his project so I'm not familiar with the codebase. Is this everything that is needed to add a new connection property?

@Kvarkas
Copy link
Member

Kvarkas commented Jul 18, 2023

@Kvarkas I'm first time contributor to his project so I'm not familiar with the codebase. Is this everything that is needed to add a new connection property?

it may need update schema but I could do it, will try to merge to test at evenining.

@Kvarkas Kvarkas marked this pull request as ready for review July 18, 2023 15:24
@Kvarkas Kvarkas merged commit 5dc8721 into mRemoteNG:v1.77.3-dev Jul 18, 2023
1 check passed
@jurepurgar jurepurgar deleted the rdgw-access-token branch July 19, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for gatewayaccesstoken RDP setting
2 participants