Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for Putty import #2508

Merged
merged 1 commit into from Oct 17, 2023
Merged

Conversation

RFC1920
Copy link
Contributor

@RFC1920 RFC1920 commented Oct 16, 2023

…rt setting

Description

Fixed import of username and port, and also made hostname match the putty key name.

Motivation and Context

bugfix

How Has This Been Tested?

Re-ran import from registry after fix and confirmed hostname, username, and port.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Changed feature (non-breaking change which changes functionality)
  • Changed feature (breaking change which changes functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated translation

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All Tests within VisualStudio are passing
  • This pull request does not target the master branch.
  • I have updated the changelog file accordingly, if necessary.
  • I have updated the documentation accordingly, if necessary.

@savornicesei
Copy link
Contributor

Hi @RFC1920
I just have 2 observations:

  1. Is there a reported bug that this PR fixes?
  2. Is it possible to have some tests for the changed code?

Thanks

@RFC1920
Copy link
Contributor Author

RFC1920 commented Oct 17, 2023

This is a fix for my previous pull request to implement putty import. As for tests, I wouldn't know how to do that currently.

@Kvarkas Kvarkas merged commit 4f7aa75 into mRemoteNG:v1.77.3-dev Oct 17, 2023
1 check passed
@Kvarkas
Copy link
Member

Kvarkas commented Oct 17, 2023

@savornicesei that for previus PR, its a new functionality not changing main code, but we dont have tests scenarios for such, will need to add later (not sure yet how exactly so will so far manual testing)

@simonai1254
Copy link
Contributor

Not sure why I'm tagged here, didn't contribute anything here...

@Kvarkas
Copy link
Member

Kvarkas commented Oct 17, 2023

oh sorry @simonai1254 you just one line below in the list, so selected in error :( I was replying to @savornicesei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants