Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire handles don’t actually shutoff engines #337

Closed
Matt726-S opened this issue Jan 28, 2021 · 15 comments
Closed

fire handles don’t actually shutoff engines #337

Matt726-S opened this issue Jan 28, 2021 · 15 comments
Milestone

Comments

@Matt726-S
Copy link

when you pull the fire handles, it “closes the related engine and spar fuel valves, closes the related engine bleed air valve, trips off the related engine generator, shuts off hydraulic fluid to the related engine-driven hydraulic pump, depressurizes the related engine-driven hydraulic pump, and arms both related engine fire extinguishers” -FCOM

in this model, the fire switches don’t do anything, they don’t even shut down the engine and just seem cosmetic.

@mSparks43
Copy link
Owner

Can't recreate this, are you turning them after you pull them out?
image

@Matt726-S
Copy link
Author

when you PULL the fire handles, they should shut down the engines and stop the flow of the things i mentioned. when you TWIST the handles after pulling them, they discharge the fire extinguisher into the engine/nacelle.

(also there is a feature in the real aircraft that locks the fire bottles so you cant pull them until there is a fire warning, or the fuel control switches are moved to cutout. the circle buttons under the bottles unlock them so you can pull the fire bottles. this doesn’t have to be implemented right now but is a nice safety feature for the future)

@remenkemi
Copy link

remenkemi commented Feb 10, 2021

The problem with that is since it's a sim, I think it'll be difficult to use that fire handle lock with a mouse. It's not like having hands.

@Matt726-S
Copy link
Author

The problem with that is since it's a sim, I think it'll be difficult to use that fire handle lock with a mouse. It's not like having hands.

i think pmdg made it so when you push it down, it’ll hold down permanently by itself until you push it.

main topic is tho, that when you pull the bottles, it should do the things that i mentioned
another thing is, when you twist the fire bottle, it should have that BTL DISCHARGE message appear immediately

@remenkemi
Copy link

This sounds like an easy fix. I'll do it.

@mSparks43 mSparks43 added this to the 3rd Release milestone Apr 30, 2021
@remenkemi
Copy link

remenkemi commented May 4, 2021

I'm trying to think of the best way of doing this. I could either fail the engines using X-Plane failures, I could just shut down the engines, or I could actually close the valves and do all the stuff the handle does irl. (Idk if the needed datarefs exist to do the last one though)

@mSparks43
Copy link
Owner

I'm trying to think of the best way of doing this.

I would say have the action the fuel switches control
image
anded with if the fire handles are extended.

BUT, pull out the fcom reference before giving it any thought/dev time, because likely its explained quite specifically in there.

@remenkemi
Copy link

Ok, I made it just flip the switches off, and in order to move them on, you need to push the fire handle back in.

@remenkemi
Copy link

I could've done it more realistically, what do you think? I can have it fire a shutdown command, and make sure the engine can't be restarted until it's pushed back in.

Or, I could actually close the engine and spar fuel valves, close the engine bleed air valve, trip off the engine generator, and shut off hydraulic fluid to the engine-driven hydraulic pump. Not sure if all those datarefs/commands exist though.

@mSparks43
Copy link
Owner

last merge is very broken, undone.

@mSparks43 mSparks43 reopened this May 15, 2021
@mSparks43 mSparks43 reopened this May 15, 2021
@remenkemi
Copy link

🤦 sorry, sorry. I thought I tested it, maybe it was different from what I posted? What was wrong?

@mSparks43
Copy link
Owner

What was wrong?

it made the fuel switch on the pedestal flick up and down

@remenkemi
Copy link

uhhh that didn't happen in testing. I must have changed something before making the pull request. Sorry.

@mSparks43
Copy link
Owner

mSparks43 commented May 15, 2021

best way to deal with this is probably in the fuel system. Find where it sets the shutdown cas message then trace back the logic and stick an "and not fire handle pulled" somewhere fuel flow is being set.

@remenkemi
Copy link

roger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants