Skip to content

Commit

Permalink
Fix compiler warning for -Wsuggest-destructor-override part3 (JDimpro…
Browse files Browse the repository at this point in the history
…ved#1312)

オーバーライドしたデストラクタにoverrideキーワードが付いていないと
コンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)
```
src/bbslist/addetcdialog.h:54:9: warning: '~AddEtcBBSMenuDialog' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
   54 |         ~AddEtcBBSMenuDialog() noexcept = default;
      |         ^
```
  • Loading branch information
ma8ma committed Dec 30, 2023
1 parent 919723c commit d7d821c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bbslist/addetcdialog.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ namespace BBSLIST
public:

AddEtcBBSMenuDialog( Gtk::Window* parent, const bool edit, const Glib::ustring& url, const Glib::ustring& name );
~AddEtcBBSMenuDialog() noexcept = default;
~AddEtcBBSMenuDialog() noexcept override = default;

std::string get_name() const { return m_entry_name.get_text(); }
std::string get_url() const { return m_entry_url.get_text(); }
Expand Down

0 comments on commit d7d821c

Please sign in to comment.