Fixed bug: If the carousel does not (yet) contain any items, the swipe

event throws an error. Even if you add items later on, the swipe doesn't work anymore.
maaaaark · Jun 10, 2017 · 20261b8 · 20261b8
1 parent 7da054c
commit 20261b8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/jquery.bcSwipe.js b/jquery.bcSwipe.js
@@ -35,6 +35,7 @@
           var difference = start - x;
           if (Math.abs(difference) >= config.threshold) {
             cancelTouch();
+            if(isCarouselEmpty($(this))) return;
             if (difference > 0) {
               $(this).carousel('next');
             }
@@ -44,6 +45,10 @@
           }
         }
       }
+
+      function isCarouselEmpty(carousel){
+	  return carousel.find(".item.active").length < 1
+      }
 
       function cancelTouch() {
         this.removeEventListener('touchmove', onTouchMove);
@@ -54,4 +59,4 @@
 
     return this;
   };
-})(jQuery);
+})(jQuery);
diff --git a/jquery.bcSwipe.min.js b/jquery.bcSwipe.min.js