improve kebab case and camel case translations

maarteNNNN · Jan 19, 2023 · a3bbeff · a3bbeff
1 parent 16ea211
commit a3bbeff
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -585,7 +585,7 @@ class REPLClient {
     if (!str) return;
     if (typeof str !== 'string')
       throw new TypeError('Not a string or no string given');
-    return str.replace(/([a-z0-9]|(?=[A-Z]))([A-Z])/g, '$1-$2').toLowerCase();
+    return str.replace(/\B([A-Z])/g, '-$1').toLowerCase();
   }
 
   /**
@@ -601,7 +601,7 @@ class REPLClient {
       throw new TypeError('Not a string or no string given');
     return str.includes('--')
       ? str.replace('--', '')
-      : str.replace(/-./g, (x) => x.toUpperCase()[1]);
+      : str.replace(/-(\w)/g, (_, c) => (c ? c.toUpperCase() : ''));
   }
 
   /**

diff --git a/test/cli.test.js b/test/cli.test.js
@@ -162,7 +162,10 @@ describe('REPL Client tests', () => {
 
       const commands = {
         options: [
-          { option: { short: 'v', long: 'version' }, help: 'Display current version' },
+          {
+            option: { short: 'v', long: 'version' },
+            help: 'Display current version',
+          },
         ],
         command: {
           execute: () => {},
@@ -298,4 +301,57 @@ describe('REPL Client tests', () => {
       chai.expect(e).to.not.throw();
     }
   });
+
+  it('it correctly translates kebab-case to camelCase', async () => {
+    try {
+      const testCli = await initiateCli(
+        { ...exampleOptions },
+        {
+          _: ['testing-this', 'testing-a-smaller-argument'],
+          // help: true,
+        },
+      );
+
+      const commands = {
+        testingThis: {
+          testingASmallerArgument: {
+            execute: ({ argument, options }) => {},
+            help: 'test this help',
+          },
+        },
+      };
+
+      await testCli.run(commands);
+    } catch (e) {
+      chai.expect(e).to.not.throw();
+    }
+  });
+
+  it('it throws if the kebab-case is off', async () => {
+    try {
+      const testCli = await initiateCli(
+        { ...exampleOptions },
+        {
+          //                        Wrong
+          _: ['testing-this', 'testing-asmaller-argument'],
+          // help: true,
+        },
+      );
+
+      const commands = {
+        testingThis: {
+          testingASmallerArgument: {
+            execute: ({ argument, options }) => {},
+            help: 'test this help',
+          },
+        },
+      };
+
+      await testCli.run(commands);
+    } catch (e) {
+      chai
+        .expect(e.message)
+        .to.be.eql('command is invalid and needs more arguments');
+    }
+  });
 });