-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming capability #42
Comments
I guess we can use the RTCDataChannel on the front-end (See this webrtc example) |
I think the PeerConnection might be more directly relevant: https://webrtc.github.io/samples/src/content/peerconnection/audio/ |
I guess you are right :) |
ping @izaid who was using websockets, but I'm not sure there is a standard we could support. Basically all the magic behind |
I think the implementation can be done better, for instance, it is now not possible to connect to a remote peer if you have the 'connection info' (basically a piece of text that goes in a RTCSessionDescription to describe the connection). You can imagine a remote camera, for which you have this info in a text file. From that description you should be able to connect to it, but currently, that's not how it is implemented. |
Hey all -- thanks for pinging me, this is very cool. I want to have a more in-depth look in the next little while. Just FYI, the reason we are using websockets is because they are pretty well supported from a non-Javascript environment, so for things like embedded devices, etc. There are a couple pretty good C / C++ websocket libraries. I looked hard for a decent WebRTC library in C / C++, but came up real short. Anyway, that's just stuff specific to me. |
Actually, if we support a stream over a websocket, ipywebrtc can be a way to convert to webrtc. Does any IP webcam work with a websocket? |
I am no expert but it seems like Google provides a native (C++) protocol implementation with examples on the WebRTC website: https://webrtc.org/native-code/native-apis/ Could be interesting to test that out. |
@maartenbreddels I'd be interested in trying this. I don't know if any IP webcam works with a websocket, but it's relatively easy to get websockets going and just stream frames encoded on the fly. @wolfv Yeah, I'm aware of the Google repository. I found that very hard to get working and ultimately not worth the effort, others may have different experiences. |
Hello, |
It could be interesting to add real audio / video streaming capability.
I am not sure how that would work in detail, but this: https://github.com/jlaine/aiortc could be a reusable implementation of the webrtc protocol in Python.
The idea would be that you could generate sound in the backend (e.g. DSP filters or similar stuff) and then stream the result to the browser / frontend.
The text was updated successfully, but these errors were encountered: