Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when using n_gram_range other than (1,1) #5

Closed
ColinFerguson opened this issue Oct 15, 2020 · 3 comments
Closed

Issue when using n_gram_range other than (1,1) #5

ColinFerguson opened this issue Oct 15, 2020 · 3 comments

Comments

@ColinFerguson
Copy link

Hi, really nice work with this package, it's very useful.

Model initiation takes the arguement n_gram_range, but I think that it doesn't get used. Should line 241 referenced here be
count = CountVectorizer(ngram_range=n_gram_range, stop_words="english").fit(documents)?

count = CountVectorizer(stop_words="english").fit(documents)

It might be nice to have the stop_words argument be configurable at initiation as well, so that the user could pass a corpus-specific set of stop words.

@MaartenGr
Copy link
Owner

You are correct! Stupid overview on my part not actually using the n_gram_range. Same with stopwords.

MaartenGr added a commit that referenced this issue Oct 17, 2020
* Fixed ngram and added stopwords
* Update pypi version
@MaartenGr
Copy link
Owner

Master has the most up-to-date version. Pypi was updated to 0.2.3 to include the changes you proposed. Let me know if you find any other issues!

@ColinFerguson
Copy link
Author

Great thank you so much @MaartenGr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants