-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when using n_gram_range other than (1,1) #5
Comments
You are correct! Stupid overview on my part not actually using the |
Master has the most up-to-date version. Pypi was updated to 0.2.3 to include the changes you proposed. Let me know if you find any other issues! |
Great thank you so much @MaartenGr |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, really nice work with this package, it's very useful.
Model initiation takes the arguement
n_gram_range
, but I think that it doesn't get used. Should line 241 referenced here becount = CountVectorizer(ngram_range=n_gram_range, stop_words="english").fit(documents)
?BERTopic/bertopic/model.py
Line 241 in 9f7dca1
It might be nice to have the
stop_words
argument be configurable at initiation as well, so that the user could pass a corpus-specific set of stop words.The text was updated successfully, but these errors were encountered: