-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJ4, CRJ, reorganized buttons, MobiFlight dependency #64
Conversation
- cj4 configuation - crj configuration - reorganized buttons/encoders order - MobiFlight dependent data - blinking gear when transition in progress - blinking yaw damper when gear is down - blinking flaps when gear is up - blinking battery when discharging - moved jinja2 stuff to separate files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow really nice. I would love to merge this. Let me know what you think of the proposed changes to the Generic functions.
@@ -1,7 +1,7 @@ | |||
{% if data.get_simvar_value('AUTOPILOT_VERTICAL_HOLD') == 1.0 %} | |||
{{ data.trigger_encoder_alternate(5, True) }} | |||
{{ data.set_encoder_led(5, True) }} | |||
{{ data.trigger_encoder_alternate(4, True) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new feature of initializing variables from the config file we could move the encoder index to a variable. This makes sure this generic function is truly generic. Currently this change breaks the default config file
{% set encoder_index = get_global_variable('AUTOPILOT_ENCODER') %}
{% if data.get_simvar_value('AUTOPILOT_VERTICAL_HOLD') == 1.0 %}
{{ data.trigger_encoder_alternate(encoder_index, True) }}
"initialization": {
"global_variables": [
{
"name": "AUTOPILOT_ENCODER",
"value": 4
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same of course applies for other functions that have been added to the generic folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this change breaks the default config file
Nevermind, just saw that the default config file was changed as well
@@ -9,12 +9,6 @@ | |||
"encoders": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there are quite a few changes in the default config file. Can you make a small list of what's changed, then when this get's merged and released I can include it in the release notes.
Added definitions for buttons/encoders indices but these are untested as of yet. I'll test it when I'm back home. |
List of changes in 1st comment. |
Merged! Thanks for contributing 👍 |
Just wanted to share with my changes. This is work in progress. Use if you want, close if you want or keep open to see future changes.