simplified import logic #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefulTex
reviewed
Jul 3, 2023
main.go
Outdated
| if err = json.NewDecoder(f).Decode(&file); err != nil { | ||
| return err | ||
| } | ||
| } else if strings.HasSuffix(importPath, ".yaml") && strings.HasSuffix(importPath, ".yml") { |
There was a problem hiding this comment.
This line requires both the .yml tag and the .yaml tag.
It should be or
maaslalani
reviewed
Jul 3, 2023
|
How does this work? If the flags aren't parsed until after the import file is read then how does the program know what the import path flag is set to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified some of the code for importing json and yaml files.
Instead of saving the flags before unmarshalling, we can simply parse the flags again after we've read in the file.