Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vim binds for right-left #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jolheiser
Copy link
Collaborator

Resolves #52

The bubble List type already has default keys that respect j and k, so this PR simply adds h and l for navigating panes.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@maaslalani
Copy link
Owner

I think we should probably use capital H and L since h and l will navigate through the pages if there are lots of snippets in the list.

@jolheiser
Copy link
Collaborator Author

Ah, I missed that when checking the default keys.

We already use L for something else, so that may not work here, and I think it may be more confusing to have two upper case and two lower case for "navigation".

I guess it comes down to this app vs the generic List bubble, what do you think makes more sense?

  1. Using this PR as general navigation and instead changing the keybinds for list paging?
  2. Changing L to something else and using all uppercase for movement
  3. Some toggle for "vim mode" that toggles between 1 above and how it works today.
  4. Something else entirely

@maaslalani
Copy link
Owner

I think generally the changing folder, file name, file extension is confusing. I believe ideally instead of separate key bindings for each we should have one key binding and then tab between the different options. What do you think? We can even replace L (for language) with E for extension.

@jolheiser
Copy link
Collaborator Author

I'm gonna get into the weeds a bit now I think, but overall folder as a collection almost seems more suited for tags.
Which leaves file and extension renaming, which I agree could be a single key to change the whole file name.

In regards to this PR specifically, even changing L so we can reuse it for vim-like bindings, I think it would be better to have all "general navigation" be the same type case, eg hjkl or HJKL
At least imo pane navigation is probably more expected than list paging for left and right.

@transcendr
Copy link

transcendr commented Feb 12, 2024

Consider changing the keybinding of the more obscure page navigation. If j/k work, you expect h/l to work. You certainly don't expect j/k/H/L. Consider n/p for pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vim-style navigation keys
3 participants