Inject HTML content after loop ends

maban · Jan 15, 2017 · 3e5c7ab · 3e5c7ab
1 parent ecc72f9
commit 3e5c7ab
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/scripts/contributors.js b/scripts/contributors.js
@@ -4,15 +4,16 @@ window.onload = function() {
   request.open('get', 'https://api.github.com/repos/maban/styleguides/contributors?&per_page=200', true)
   request.send()
   function outputContributors() {
-    var contributors = JSON.parse(this.responseText);
-    var injectContributors = document.getElementById("people");
+    var contributors = JSON.parse(this.responseText),
+        injectContributors = document.getElementById('people'),
+        html = '';
     for (i in contributors) {
-      var username = contributors[i].login
-      var avatar = contributors[i].avatar_url
-      var url = contributors[i].html_url
-      var contributions = contributors[i].contributions
-      var html = '<li class="person"><a class="person__url" href="'+ url +'"><img src="' + avatar + '" alt="" width="50" class="person__avatar" title="' + username + '"/></a></li>';
-      injectContributors.innerHTML += (html);
+      var username = contributors[i].login,
+          avatar = contributors[i].avatar_url,
+          url = contributors[i].html_url,
+          contributions = contributors[i].contributions;
+      html += '<li class="person"><a class="person__url" href="'+ url +'"><img src="' + avatar + '" alt="" width="50" class="person__avatar" title="' + username + '"/></a></li>';
     }
+    injectContributors.innerHTML = html;
   }
 }