Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement SOUNDEX #364

Closed
joocer opened this issue Aug 20, 2022 · 1 comment
Closed

✨ Implement SOUNDEX #364

joocer opened this issue Aug 20, 2022 · 1 comment
Labels
Awaiting Closure Fixed - waiting for merging/releasing

Comments

@joocer
Copy link
Contributor

joocer commented Aug 20, 2022 •
edited

#370

https://link.medium.com/5icTG6NEIsb

Check license and add to notifications
@joocer joocer changed the title [FEATURE] Implement SOUNDEX ✨ Implement SOUNDEX Aug 20, 2022
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
FEATURE/#364
0bc141e
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
FEATURE/#364
a25e90c
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
FEATURE/#364
1dcca00
@joocer
Copy link
Contributor Author

joocer commented Aug 27, 2022 •
edited

Implemented in 0.3 - whilst soundex is interesting, the key reason for early implementation is to help ensure we know how to include pyx files into the build. A fairly unused function was chosen to do this as previous attempts for something more core causes failures - this should only fail (if it fails) when SOUNDEX is explicitly called.

@joocer joocer added the Awaiting Closure Fixed - waiting for merging/releasing label Aug 27, 2022
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
Merge pull request #422 from mabel-dev/FEATURE/#364
b9bbda9 
Feature/#364
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
FEATURE/#364
2fb3a38
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
FEATURE/#364
e7ca0d9
joocer added a commit that referenced this issue Aug 27, 2022
@joocer
Merge pull request #423 from mabel-dev/FEATURE/#364
21caa68 
Feature/#364
@joocer joocer closed this as completed Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Closure Fixed - waiting for merging/releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joocer